[
https://issues.apache.org/jira/browse/ACCUMULO-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617973#comment-14617973
]
Josh Elser commented on ACCUMULO-1680:
--------------------------------------
Sorry for the extreme delay in looking at this.
The patch looks good in general, but it did fail some findbugs checks.
{noformat}
[INFO] --- findbugs-maven-plugin:3.0.1:check (run-findbugs) @ accumulo-shell ---
[INFO] BugInstance size is 3
[INFO] Error size is 0
[INFO] Total bugs: 3
[INFO] The method name
org.apache.accumulo.shell.commands.DeleteAuthsCommandTest.DeleteAllAuth()
doesn't start with a lower case letter
[org.apache.accumulo.shell.commands.DeleteAuthsCommandTest] At
DeleteAuthsCommandTest.java:[lines 103-127]
[INFO] The method name
org.apache.accumulo.shell.commands.DeleteAuthsCommandTest.DeleteExistingAuth()
doesn't start with a lower case letter
[org.apache.accumulo.shell.commands.DeleteAuthsCommandTest] At
DeleteAuthsCommandTest.java:[lines 47-71]
[INFO] The method name
org.apache.accumulo.shell.commands.DeleteAuthsCommandTest.DeleteNonExistingAuth()
doesn't start with a lower case letter
[org.apache.accumulo.shell.commands.DeleteAuthsCommandTest] At
DeleteAuthsCommandTest.java:[lines 75-99]
{noformat}
You're welcome to send a new patch, otherwise, I can just fix the errors.
> Atomic add and remove of authorizations
> ---------------------------------------
>
> Key: ACCUMULO-1680
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1680
> Project: Accumulo
> Issue Type: New Feature
> Components: client, master, shell
> Affects Versions: 1.6.2
> Reporter: Chad Hardin
> Assignee: Eric Robertson
> Priority: Minor
> Labels: newbie, summit2015
> Fix For: 1.8.0
>
> Attachments: ACCUMULO-1680.patch
>
>
> Currently, adding and removing an auth presents a race condition because of
> the two separate calls required to get, modify, then set the authorizations
> for a user.
> Instead, it should be possible to add or remove one or more auths without
> there being a race condition.
> I also propose adding two new commands to the shell to expose this
> functionality.
> It appears to be that this is not a difficult feature to add, by making use
> of ZooReaderWriter.mutate() in the FATE packages. I think the bulk of the
> work will be in changing the various interfaces (shell and programmatically)
> to expose this functionality.
> I would like to do this work and I'm a accumulo newbie, so any guidance would
> be appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
