[
https://issues.apache.org/jira/browse/ACCUMULO-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619748#comment-14619748
]
ASF GitHub Bot commented on ACCUMULO-3920:
------------------------------------------
GitHub user ctubbsii opened a pull request:
https://github.com/apache/accumulo/pull/40
ACCUMULO-3920 Deprecate mock components
== Done so far ==
* Deprecate Accumulo Mock classes
* Add javadoc to mock package to add additional details
* Create `DeprecationUtil` to help migrate code which must continue to use
mock
* Minimize mock usage throughout the tests wherever possible
* Use `EasyMock` in a few cases where it was possible to satisfy the test
* Apply `@Rule`, `@Before`, etc. to reduce number of calls to
`MockInstance`
* Create replacement `IteratorAdapter` for use outside of mock
== Could use help with ==
(most of these can be pretty readily identified in Eclipse with deprecation
warnings shown)
* Migrating `FormatterCommandTest.java` to avoid use of `MockShell`
* Migrating MapReduce tests and other "heavyweight" tests to use
`MiniAccumuloCluster`
* Migrating other "lightweight" tests to use `EasyMock`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ctubbsii/accumulo ACCUMULO-3920
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 048f56cf6340dbcee5eec154753734bebe3bc45f
Author: Christopher Tubbs <[email protected]>
Date: 2015-07-09T02:02:03Z
ACCUMULO-3920 Deprecate mock components
* Deprecate Accumulo Mock classes
* Add javadoc to mock package to add additional details
* Create DeprecationUtil to help migrate code which must continue to use
mock
* Minimize mock usage throughout the tests wherever possible
* Use EasyMock in a few cases where it was possible to satisfy the test
* Apply @Rule, @Before, etc. to reduce number of calls to MockInstance
* Create replacement IteratorAdapter for use outside of mock
----
> Deprecate mock and cease using it in our tests
> ----------------------------------------------
>
> Key: ACCUMULO-3920
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3920
> Project: Accumulo
> Issue Type: Task
> Reporter: Christopher Tubbs
> Assignee: Christopher Tubbs
> Fix For: 1.8.0
>
>
> Numerous prior discussions have occurred, expressing a desire to deprecate
> (deprecate is not the same as remove) mock, so we can properly communicate
> its current status as a "dying" (poorly maintained, not kept up-to-date,
> lacking features) component of Accumulo. Some interest has been expressed in
> keeping it around, but no work has been put in to it to fix it's numerous
> divergences from the behavior of "real" Accumulo, add its missing features,
> or to improve its API.
> The task here is to:
> * Cease and desist using mock in our tests (replacing it with MAC, EasyMock,
> etc., as appropriate)
> * Mark mock {{@Deprecated}} until it is eventually removed in a major release
> Further discussion, if necessary, can be held later regarding its actual
> removal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
