[ https://issues.apache.org/jira/browse/ACCUMULO-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740162#comment-14740162 ]
Sean Busbey commented on ACCUMULO-3991: --------------------------------------- {quote} We should probably put the generic text of the MIT and BSD licenses in the LICENSE file, so we can just include them once for all bundled software to which that license applies, and move the copyright notices to the NOTICE file. I believe that's the correct way of utilizing these files. {quote} The current patch is done according to the [guidance on properly assembling license and notice files|http://www.apache.org/dev/licensing-howto.html]: permissive licensed works only in LICENSE, ASLv2 licensed works w/NOTICE file in NOTICE. It also only contains a single copy of each of the MIT and BSD-3 licenses referenced. {quote} Hey Sean, the files mentioned in ACCUMULO-3989 are based on old HBase versions of the same (thus the copyright notice in their headers). See http://s.apache.org/JXi for reference; that was a while ago, but some of it is still relevant. {quote} Ah. Should we include a "Portions from Apache HBase" notice in the NOTICE file? HBase didn't have a NOTICE file that included a copyright statement until very recently, so it's almost certain that the version these were copied from didn't include it; I think we'd be fine to just use as-is. Though perhaps a note about the history in the source file would be nice? {quote} bq. +server/src/main/java/org/apache/accumulo/server/util/TNonblockingServerSocket.java This file moves around across the branches. I'd prefer to see us just refer to the filename which should be unique. Would be nice to do that for the bloomfilters package, but a bit more difficult. Maybe enumerate those files instead of listing the package? What do you think? Otherwise, the patch lgtm. {quote} both excellent ideas, let me fix that up. > fix source tarball LICENSE /NOTICE files > ---------------------------------------- > > Key: ACCUMULO-3991 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3991 > Project: Accumulo > Issue Type: Sub-task > Components: build > Reporter: Sean Busbey > Assignee: Sean Busbey > Fix For: 1.5.4 > > Attachments: ACCUMULO-3991.1.patch > > > see parent issue for details -- This message was sent by Atlassian JIRA (v6.3.4#6332)