Adam Fuchs created ACCUMULO-4037:
------------------------------------

             Summary: avoid a key copy in TimeSettingIterator
                 Key: ACCUMULO-4037
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4037
             Project: Accumulo
          Issue Type: Improvement
          Components: core
    Affects Versions: 1.7.0
            Reporter: Adam Fuchs
            Priority: Minor


In org.apache.accumulo.core.iterators.system.TimeSettingIterator we make a copy 
of the key before setting the time. Seems like this is a completely superfluous 
copy, and we should avoid it. In the current code we do the following:

{code}
  @Override
  public Key getTopKey() {
    Key key = new Key(source.getTopKey());
    key.setTimestamp(time);
    return key;
  }
{code}

Instead we should do this:
{code}
  @Override
  public Key getTopKey() {
    Key key = source.getTopKey();
    key.setTimestamp(time);
    return key;
  }
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to