[
https://issues.apache.org/jira/browse/ACCUMULO-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114254#comment-15114254
]
ASF GitHub Bot commented on ACCUMULO-4115:
------------------------------------------
GitHub user ctubbsii opened a pull request:
https://github.com/apache/accumulo/pull/65
ACCUMULO-4115 Use undated annotations
Uses undated annotations for thrift-generated java classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4115
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit ee7b24ab7ba227c0ff16d4684de87be77438d8c1
Author: Christopher Tubbs <[email protected]>
Date: 2016-01-24T09:34:40Z
Use undated option for thrift java generation
Use generated_annotations=undated to prevent changing generated files
every time the build is run with the thrift profile active.
commit d43685c9898bc4aa17689cebcbb9766c208dda87
Author: Christopher Tubbs <[email protected]>
Date: 2016-01-24T09:38:51Z
Regenerate thrift without dated annotations
----
> Thrift generation always replaces files
> ---------------------------------------
>
> Key: ACCUMULO-4115
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4115
> Project: Accumulo
> Issue Type: Bug
> Reporter: Christopher Tubbs
> Fix For: 1.8.0
>
>
> Since the switch to thrift 0.9.3 in ACCUMULO-4077, all thrift-generated files
> get a {{"date = %Y-%m-%d"}} (I'm using `man date` syntax here) parameter to a
> {{@Generated}} annotation. This causes all checked-in files to be replaced
> whenever the {{-Pthrift}} profile is used.
> This is going to cause problems for us when we run the release plugin, which
> activates this profile, and will cause the resulting builds to differ from
> checked-in code. It will also create a lot of noise in git when making small
> changes to thrift classes.
> Rather than copy over all changed files when running with the thrift profile,
> we should only copy over files which differ by more than the date in this
> annotation. Alternatively, we can suppress the dates using the java option
> for thrift {{generated_annotations=undated}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
