[
https://issues.apache.org/jira/browse/ACCUMULO-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153217#comment-15153217
]
ASF GitHub Bot commented on ACCUMULO-4138:
------------------------------------------
Github user mjwall commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/71#discussion_r53391009
--- Diff:
core/src/main/java/org/apache/accumulo/core/util/shell/commands/OptUtil.java ---
@@ -117,7 +117,7 @@ public static OptionGroup addListDeleteGroup(final
String name) {
}
public static Option startRowOpt() {
- final Option o = new Option(START_ROW_OPT, "begin-row", true, "begin
row (inclusive)");
+ final Option o = new Option(START_ROW_OPT, "begin-row", true, "begin
row (NOT) inclusive");
--- End diff --
I can do that. The reason I used (NOT) inclusive was to make the merge
command not change it's current description. See
https://github.com/apache/accumulo/blob/1.6/core/src/main/java/org/apache/accumulo/core/util/shell/commands/MergeCommand.java#L100
> CompactCommand description is incorrect
> ---------------------------------------
>
> Key: ACCUMULO-4138
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4138
> Project: Accumulo
> Issue Type: Bug
> Components: shell
> Affects Versions: 1.6.4, 1.7.0
> Reporter: Michael Wall
> Assignee: Michael Wall
> Labels: newbie
> Fix For: 1.6.6, 1.7.2, 1.8.0
>
>
> The compact command has the following description
> {code}
> root@accumulo> compact -?
> usage: compact [<table>{ <table>}] [-?] [-b <begin-row>] [--cancel] [-e
> <end-row>] [-nf] [-ns <namespace> | -p <pattern> | -t <tableName>] [-pn
> <profile>] [-w]
> description: sets all tablets for a table to major compact as soon as
> possible (based on current time)
> -?,--help display this help
> -b,--begin-row <begin-row> begin row (inclusive)
> --cancel cancel user initiated compactions
> -e,--end-row <end-row> end row (inclusive)
> -nf,--noFlush do not flush table data in memory before
> compacting.
> -ns,--namespace <namespace> name of a namespace to operate on
> -p,--pattern <pattern> regex pattern of table names to operate on
> -pn,--profile <profile> iterator profile name
> -t,--table <tableName> name of a table to operate on
> -w,--wait wait for compact to finish
> {code}
> However, the --begin-row is not inclusive. Here is a simple demonstration.
> {code}
> createtable compacttest
> addsplits a b c
> insert "a" "1" "" ""
> insert "a" "2" "" ""
> insert "b" "3" "" ""
> insert "b" "4" "" ""
> insert "c" "5" "" ""
> insert "c" "6" "" ""
> flush -w
> scan -t accumulo.metadata -np
> compact -b a -e c -t compacttest -w
> scan -t accumulo.metadata -np
> deletetable compacttest -f
> {code}
> You will see that file associated with the 'a' split is still a F flush file,
> which the files in the 'b' and 'c' split are A files.
> Not sure if the fix is to update the commands description, which would be
> easy, or to make the begin row actually inclusive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
