[ 
https://issues.apache.org/jira/browse/ACCUMULO-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437747#comment-15437747
 ] 

Christopher Tubbs commented on ACCUMULO-4058:
---------------------------------------------

Is this worth pursuing? This is a build test. Do we need to support running 
these outside of the build? If we do, then the class itself should create the 
jar in code, on demand. But, I'm not convinced that's worth supporting. The 
test is already tied to Maven, using the target directories, etc.

At the very least, I don't think this is "Critical" as it is currently marked.

> mvn test on ScannerContextIT will fail if test jar is not already built.
> ------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4058
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4058
>             Project: Accumulo
>          Issue Type: Bug
>          Components: test
>            Reporter: Josh Elser
>            Priority: Critical
>              Labels: newbie
>             Fix For: 1.8.1
>
>
> https://github.com/apache/accumulo/blob/master/test/pom.xml#L230
> {code}
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-jar-plugin</artifactId>
>           <executions>
>             <execution>
>               <goals>
>                 <goal>test-jar</goal>
>               </goals>
>               <phase>pre-integration-test</phase>
>               <configuration>
>                 <finalName>TestIterators</finalName>
>                 <classifier />
>                 <includes>
>                   
> <include>org/apache/accumulo/test/functional/ValueReversingIterator.class</include>
>                 </includes>
>               </configuration>
>             </execution>
>           </executions>
>         </plugin>
> {code}
> Binding this to pre-integration-test instead of test-compile (or something 
> else) will likely break the test that requires this special jar if the test 
> is manually invoked. This is a common pattern among devs (although {{mvn 
> verify -Dit.test}} is more correct).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to