[ 
https://issues.apache.org/jira/browse/ACCUMULO-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446412#comment-15446412
 ] 

Josh Elser commented on ACCUMULO-4428:
--------------------------------------

bq. I was thinking of just making the firstSeenDead map static. I don't see a 
change like that having any adverse side effects.

I had talked to Mike in IRC and we had the same idea. We also thought that it 
might be better to just make the GarbageCollectWriteAheadLogs instance a 
singleton inside of SimpleGarbageCollector to avoid unnecessary static state.

bq. ok with me moving this ticket back to 1.8.1 and proceeding with the rc for 
1.8.0

Great. I am OK with just dropping the 1.8.x completely and dealing with this in 
ACCUMULO-4333 instead.

> GC does not delete WAL files belonging to dead tservers
> -------------------------------------------------------
>
>                 Key: ACCUMULO-4428
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4428
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.2
>            Reporter: Adam J Shook
>            Assignee: Michael Wall
>            Priority: Blocker
>             Fix For: 1.7.3, 1.8.0
>
>
> The GarbageCollectWriteAheadLogs uses a Map<HostAndPort,Long> to track when 
> it had first seen a dead tserver, waiting an hour before deleting the files.  
> However, a new instance of this class is re-created during each run of the 
> SimpleGarbageCollector, causing the state of the dead tservers to be lost.  
> All of the WAL files belonging to a dead tserver will never be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to