[
https://issues.apache.org/jira/browse/ACCUMULO-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683930#comment-15683930
]
Hadoop QA commented on ACCUMULO-4519:
-------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} pylint {color} | {color:blue} 0m 0s
{color} | {color:blue} Pylint was not available. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 8s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 47s
{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
5s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 51s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12839670/ACCUMULO-4519.0000.patch
|
| JIRA Issue | ACCUMULO-4519 |
| Optional Tests | asflicense javac javadoc unit cc compile findbugs
checkstyle pylint rubocop ruby_lint |
| uname | Linux asf917.gq1.ygridcore.net 4.4.0-43-generic #63-Ubuntu SMP Wed
Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-ACCUMULO-Build/test_framework/yetus-0.3.0/lib/precommit/personality/accumulo.sh
|
| git revision | master / 2551c2a |
| Default Java | 1.8.0_102 |
| findbugs | v3.0.1 |
| Test Results |
https://builds.apache.org/job/PreCommit-ACCUMULO-Build/52/testReport/ |
| modules | C: proxy U: proxy |
| Console output |
https://builds.apache.org/job/PreCommit-ACCUMULO-Build/52/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> System permission bug in Thrift Proxy
> -------------------------------------
>
> Key: ACCUMULO-4519
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4519
> Project: Accumulo
> Issue Type: Bug
> Components: proxy
> Affects Versions: 1.8.0
> Reporter: Yudong Wu
> Fix For: 1.7.3, 1.8.1, 2.0.0
>
> Attachments: ACCUMULO-4519.0000.patch
>
>
> The system permission list between core and Thrift proxy is inconsistent. The
> proxy lacks the support for some of the newly added system permissions,
> including:
> {{System.CREATE_NAMESPACE}}
> {{System.DROP_NAMESPACE}}
> {{System.ALTER_NAMESPACE}}
> {{System.OBTAIN_DELEGATION_TOKEN}}
> Currently, when connecting through Thrift proxy, we can't grant, check or
> revoke the above 4 System permissions. When a proxy client sends permissions
> (i.e., {{System.CREATE_NAMESPACE}}), it will receive {{AccumuloException}}
> wrapping around {{java.lang.NullPointerException}}:
> {code:borderStyle=solid}
> Traceback (most recent call last):
> File "Client.py", line 32, in <module>
> client.grantSystemPermission(login, username, CREATE_NAMESPACE_PERM)
> File "***AccumuloProxy.py", line 2980, in grantSystemPermission
> self.recv_grantSystemPermission()
> File "***AccumuloProxy.py", line 3006, in recv_grantSystemPermission
> raise result.ouch1
> accumulo.ttypes.AccumuloException:
> AccumuloException(msg='java.lang.NullPointerException')
> {code}
> The bug is in the Thrift proxy file
> {code:title=accumulo/proxy/src/main/thrift/proxy/thrift|borderStyle=solid}
> enum SystemPermission {
> GRANT = 0,
> CREATE_TABLE = 1,
> DROP_TABLE = 2,
> ALTER_TABLE = 3,
> CREATE_USER = 4,
> DROP_USER = 5,
> ALTER_USER = 6,
> SYSTEM = 7,
> }
> {code}
> The {{SystemPermission}} enum clearly misses Permission #8--#11 defined in
> Accumulo core:
> {code:title=accumulo/core/.../SystemPermission.java|borderStyle=solid}
> public enum SystemPermission {
> /*
> * One may add new permissions, but new permissions must use new numbers.
> Current numbers in use must not be changed.
> */
> GRANT((byte) 0),
> CREATE_TABLE((byte) 1),
> DROP_TABLE((byte) 2),
> ALTER_TABLE((byte) 3),
> CREATE_USER((byte) 4),
> DROP_USER((byte) 5),
> ALTER_USER((byte) 6),
> SYSTEM((byte) 7),
> CREATE_NAMESPACE((byte) 8),
> DROP_NAMESPACE((byte) 9),
> ALTER_NAMESPACE((byte) 10),
> OBTAIN_DELEGATION_TOKEN((byte) 11);
> }
> {code}
> The fix should be straightforward---just add the corresponding permissions
> into the Thrift proxy file.
> Let me know if you need any more info, or want a patch for this.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
