[ https://issues.apache.org/jira/browse/ACCUMULO-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730061#comment-15730061 ]
ASF GitHub Bot commented on ACCUMULO-4511: ------------------------------------------ Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo-examples/pull/1#discussion_r91397755 --- Diff: run.sh --- @@ -0,0 +1,21 @@ +#! /usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +main_class="$1" +main_args="${@:2}" --- End diff -- Also, ".sh" is bad naming convention. In the new repo, we have the opportunity to change it... and maybe put it in a directory more appropriate than the root of a Maven project. > Put examples in their own git repo > ---------------------------------- > > Key: ACCUMULO-4511 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4511 > Project: Accumulo > Issue Type: Task > Components: examples > Reporter: Christopher Tubbs > Priority: Minor > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Accumulo examples can be put in their own repo. > The examples (if they were to depend solely on the public API) could be on a > separate release cadence than the rest of Accumulo and work across multiple > versions. They do not need to be versioned with, or contained within the > Accumulo convenience binary tarball. Instead, they could be part of a series > of instructional tours on the Accumulo website. > We can request a new git repo easily at https://reporeq.apache.org -- This message was sent by Atlassian JIRA (v6.3.4#6332)