Christopher Tubbs commented on ACCUMULO-4681:

Yeah, the de-duping handles the creating lots of references to the same 
namespace id, while the WeakHashMap allows the JVM to garbage collect these 
de-duped references once the user is done with them, so the map itself need not 
be any larger than necessary.

> Create WeakReference Map to replace Table.ID constructor
> --------------------------------------------------------
>                 Key: ACCUMULO-4681
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4681
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Michael Miller
>            Assignee: Michael Miller
>            Priority: Minor
>             Fix For: 2.0.0
> Taken from feedback on the PR #279:
> Could maybe avoid duplicates by making constructor (of Table.ID) private and 
> doing Table.ID.of(tableId), which draws from an internal WeakReference map.
> If the object deduplication in KeyExtent is still valid, this can be pushed 
> down to the Table.ID and Namespace.ID classes, replacing the optimization in 
> KeyExtent.

This message was sent by Atlassian JIRA

Reply via email to