ctubbsii commented on a change in pull request #294: Accumulo 3652 sl4j
refactoring
URL: https://github.com/apache/accumulo/pull/294#discussion_r136453075
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java
##########
@@ -71,7 +71,7 @@ public RecoveryManager(Master master) {
List<String> workIDs = new
DistributedWorkQueue(ZooUtil.getRoot(master.getInstance()) +
Constants.ZRECOVERY, aconf).getWorkQueued();
sortsQueued.addAll(workIDs);
} catch (Exception e) {
- log.warn("{}", e.getMessage(), e);
+ log.warn(e.getMessage(), e);
Review comment:
The old version is a little bit better, I think, because it prevents the
exception's message from being interpreted as a format string. In other words,
if the message itself contains braces, then this won't behave as expected. This
is unlikely (because braces in the exception message are rare), but possible.
This change occurs in a few other places, as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
