milleruntime commented on issue #295: ACCUMULO-4699 Fixed queued work key in replication URL: https://github.com/apache/accumulo/pull/295#issuecomment-327306042 > I made a statement was essentially "-0" (would prefer this to not be merged as-is) That is my mistake. I took your comments as +0. Then I merged the PR without the intention of writing a test. As far as the test goes, I appreciate your explanations but I don't think we need a test for this fix. It is not new code and the only reason I opened the PR was for someone else more familiar with replication to take a look at it. The only thing I was going to do further was to open up a JIRA ticket for follow on work of creating a test if you thought it was needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
