[ 
https://issues.apache.org/jira/browse/ACCUMULO-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160478#comment-16160478
 ] 

Piotr Findeisen commented on ACCUMULO-4701:
-------------------------------------------

[~ctubbsii], that's good!

Then I don't know what problems would shading of Guava _introduce_ for projects 
using Accumulo. (And i think I know what problems will it _solve_)

As it is now, I can't use Accumulo and Guava 22. This is because Accumulo uses 
Guava 14 and e.g {{HostAndPort}} class (marked {{@Beta}} in that Guava 14) and 
Guava decided to deprecate and later remove {{getHostText()}} method.

According to Guava docs: 
https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis , if you use 
Beta APIs and you are a library, you should shade (repackage) the Guava 
dependency. In fact, even if you do not use Beta APIs, then you should still 
upgrade quite regularly 
(https://github.com/google/guava/wiki/PhilosophyExplained#non-beta-apis). Since 
Guava 14 they had enough time to deprecate and remove non-Beta APIs too.



> Shade Guava dependency
> ----------------------
>
>                 Key: ACCUMULO-4701
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4701
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.7.3
>            Reporter: Piotr Findeisen
>            Assignee: Christopher Tubbs
>
> [{{presto-accumulo}}|https://github.com/prestodb/presto/tree/master/presto-accumulo]
>  connector embeds Accumulo client {{org.apache.accumulo:accumulo-core}}. 
> Accumulo uses Guava. Since Guava APIs are not strictly backwards compatible, 
> it's necessary to shade guava dependency or library users need to use same 
> Guava version (i.e. cannot upgrade/downgrade at will).
> Please shade Guava dependency.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to