ctubbsii commented on a change in pull request #300: ACCUMULO-4708 Limit RFile
block size to 2GB
URL: https://github.com/apache/accumulo/pull/300#discussion_r140602218
##########
File path:
core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java
##########
@@ -2271,4 +2273,40 @@ public void testRootTabletEncryption() throws Exception
{
conf = null;
}
+
+ @Rule
+ public ExpectedException exception = ExpectedException.none();
+
+ @Test
+ public void testKeyTooLarge() throws Exception {
+ // If we don't have enough memory (6G) skip these very memory-intensive
unit tests
+ Assume.assumeTrue(Runtime.getRuntime().maxMemory() >= 5726797824L);
Review comment:
It's not clear where these numeric literals come from. Perhaps it can be put
in a variable, and their computation shown, so it's clear where they come from?
If they are arbitrary, then a comment explaining that (eg. "arbitrary size in
the range of ... ") would be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
