joshelser commented on a change in pull request #305: [ACCUMULO-4591] Add
replication latency metrics
URL: https://github.com/apache/accumulo/pull/305#discussion_r144058516
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/metrics/Metrics2ReplicationMetrics.java
##########
@@ -26,38 +29,51 @@
import org.apache.accumulo.master.Master;
import org.apache.accumulo.server.metrics.Metrics;
import org.apache.accumulo.server.replication.ReplicationUtil;
+import org.apache.hadoop.fs.Path;
import org.apache.hadoop.metrics2.MetricsCollector;
import org.apache.hadoop.metrics2.MetricsRecordBuilder;
import org.apache.hadoop.metrics2.MetricsSource;
import org.apache.hadoop.metrics2.MetricsSystem;
import org.apache.hadoop.metrics2.lib.Interns;
import org.apache.hadoop.metrics2.lib.MetricsRegistry;
+import org.apache.hadoop.metrics2.lib.MutableQuantiles;
+import org.apache.hadoop.metrics2.lib.MutableStat;
/**
*
*/
public class Metrics2ReplicationMetrics implements Metrics, MetricsSource {
public static final String NAME = MASTER_NAME + ",sub=Replication",
DESCRIPTION = "Data-Center Replication Metrics", CONTEXT = "master",
RECORD = "MasterReplication";
- public static final String PENDING_FILES = "filesPendingReplication",
NUM_PEERS = "numPeers", MAX_REPLICATION_THREADS = "maxReplicationThreads";
+ public static final String PENDING_FILES = "filesPendingReplication",
NUM_PEERS = "numPeers", MAX_REPLICATION_THREADS = "maxReplicationThreads",
+ REPLICATION_QUEUE_TIME_QUANTILES = "replicationQueue10m",
REPLICATION_QUEUE_TIME = "replicationQueue";
private final Master master;
private final MetricsSystem system;
private final MetricsRegistry registry;
private final ReplicationUtil replicationUtil;
+ private final MutableQuantiles replicationQueueTimeQuantiles;
+ private final MutableStat replicationQueueTimeStat;
+ private final Map<Path,Long> pathModTimes;
Metrics2ReplicationMetrics(Master master, MetricsSystem system) {
this.master = master;
this.system = system;
+ pathModTimes = new HashMap<>();
+
registry = new MetricsRegistry(Interns.info(NAME, DESCRIPTION));
replicationUtil = new ReplicationUtil(master);
+ replicationQueueTimeQuantiles =
registry.newQuantiles(REPLICATION_QUEUE_TIME_QUANTILES, "replication queue time
quantiles in milliseconds", "ops",
Review comment:
nit: capitalize "Replication" please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
