keith-turner commented on a change in pull request #319: ACCUMULO-4737 Clean up
cipher algorithm configuration
URL: https://github.com/apache/accumulo/pull/319#discussion_r149447988
##########
File path:
core/src/main/java/org/apache/accumulo/core/security/crypto/CryptoModuleFactory.java
##########
@@ -239,14 +239,6 @@ public CryptoModuleParameters
initializeCipher(CryptoModuleParameters params) {
}
- public static String[] parseCipherTransform(String cipherTransform) {
- if (cipherTransform == null) {
- return new String[3];
- }
-
- return cipherTransform.split("/");
Review comment:
This parsing was bad, it did no validation. It seems like this changes
removes all custom parsing and uses java standard libs to do the parsing, is
this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
