PircDef commented on a change in pull request #319: ACCUMULO-4737 Clean up
cipher algorithm configuration
URL: https://github.com/apache/accumulo/pull/319#discussion_r149473710
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -48,10 +48,18 @@
"Fully qualified class name of the class that implements the
CryptoModule interface, to be used in setting up encryption at rest for the WAL
and "
+ "(future) other parts of the code."),
@Experimental
- CRYPTO_CIPHER_SUITE("crypto.cipher.suite", "NullCipher",
PropertyType.STRING, "Describes the cipher suite to use for the write-ahead
log"),
+ CRYPTO_CIPHER_SUITE("crypto.cipher.suite", "NullCipher", PropertyType.STRING,
+ "Describes the cipher suite to use for rfile encryption. If a WAL cipher
suite is not set, it will default to this value. The suite should be in the "
+ + "form of algorithm/mode/padding, e.g. AES/CBC/NoPadding"),
@Experimental
- CRYPTO_CIPHER_ALGORITHM_NAME("crypto.cipher.algorithm.name", "NullCipher",
PropertyType.STRING,
- "States the name of the algorithm used in the corresponding cipher
suite. Do not make these different, unless you enjoy mysterious exceptions and
bugs."),
+ CRYPTO_WAL_CIPHER_SUITE(
+ "crypto.wal.cipher.suite",
+ "NullCipher",
+ PropertyType.STRING,
+ "Describes the cipher suite to use for the write-ahead log. Defaults to
'cyrpto.cipher.suite' and will use that value for WAL encryption unless
otherwise specified."),
+ @Experimental
+ CRYPTO_CIPHER_KEY_ALGORITHM_NAME("crypto.cipher.key.algorithm.name",
"NullCipher", PropertyType.STRING,
+ "States the name of the algorithm used for the key for the corresponding
cipher suite. The key type must be compatible with the cipher suite."),
Review comment:
If the key name is not set, but the cipher suite is, then the key will try
to be initialized with a null value, which causes an InvalidKeyException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
