[
https://issues.apache.org/jira/browse/ACCUMULO-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ACCUMULO-4743:
-------------------------------------
Labels: pull-request-available (was: )
> Use tserver prefix for Cache config instead of general custom
> -------------------------------------------------------------
>
> Key: ACCUMULO-4743
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4743
> Project: Accumulo
> Issue Type: Bug
> Reporter: Keith Turner
> Labels: pull-request-available
> Fix For: 2.0.0
>
>
> In ACCUMULO-4463 caching implementations were made configurable. At the time
> config for a cache was placed under the {{general.custom.cache}} prefix. The
> idea was that a cache impl would be passed in a AccumuloConfiguration object
> and it could grab whatever it wanted from {{general.custom.cache}}.
> In ACCUMULO-4644 the cache API was changed to not use AccumuloConfiguration
> because that type is not in the public API. This removed the reason for
> using general.custom in the first place.
> When trying to implement an external cache I discovered that I can not set
> general.custom props in zookeeper. However the cache class is a tserver
> prefixed property can can be set in zookeeper. For the
> [accumulo-ohc|https://github.com/keith-turner/accumulo-ohc] I wanted to do
> the following in the shell but could not set the general props.
> {noformat}
> config -s general.custom.cache.ohc.data.on-heap.maximumWeight=1000000000
> config -s general.custom.cache.ohc.data.off-heap.capacity=10000000000
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> I think it would be nice to change cache config prefix from
> {{general.custom.cache.<scope>.<user prop>}} to
> {{tserver.cache.config.<scope>.<user prop>}}. Doing this would enable
> setting up a cache in the shell like the following.
> {noformat}
> config -s tserver.cache.config.data.on-heap.maximumWeight=1000000000
> config -s tserver.cache.config.data.off-heap.capacity=10000000000
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> Part of the code for this prefix is at [BlockCacheManager.java line
> 33|https://github.com/apache/accumulo/blob/d877a2df2943e48d70d99b96616844d0dff9a501/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java#L33]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
