jomach commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154454411
##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
##########
@@ -354,12 +354,8 @@ public void run() {
}
private static void stopServer(final ClientContext context, final boolean
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
- MasterClient.executeVoid(context, new
ClientExec<MasterClientService.Client>() {
- @Override
- public void execute(MasterClientService.Client client) throws Exception {
- client.shutdown(Tracer.traceInfo(), context.rpcCreds(),
tabletServersToo);
- }
- });
+ MasterClient.executeVoidWithConnRetry(context,
Review comment:
From my understanding this gets called when some client tries to execute a
operation on accumulo. Is this correct ? So if I have an application having
some networking timeout (let?s say the cable is out) then it will brake the
application and the application will need to take care of retry. At the moment
the code does already this. That?s my I think it would be better to have a
method only for the admin tasks. Like starting stopping creating tables ...
Correct me if I?m wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
