ctubbsii commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154789645
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java
##########
@@ -44,14 +44,14 @@
public static MasterClientService.Client
getConnectionWithRetry(ClientContext context) {
while (true) {
- MasterClientService.Client result = getConnection(context);
+ MasterClientService.Client result = getConnection(context, false);
Review comment:
In order to limit the number of changes, it's better to keep a method with
the original method signature that wraps the new version with the extra
parameter, so this (and other callers which are expected to keep their original
behavior) is unaffected by this change.
Example:
```java
public static MasterClientService.Client getConnection(ClientContext
context) {
return getConnection(context, false); // or getConnection(context, 0) with
my suggestion to specify the timeout
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
