ctubbsii commented on a change in pull request #331: ACCUMULO-4756 Allow
default tables validate REST
URL: https://github.com/apache/accumulo/pull/331#discussion_r155366297
##########
File path:
server/monitor/src/main/java/org/apache/accumulo/monitor/util/ParameterValidator.java
##########
@@ -22,6 +22,8 @@
public interface ParameterValidator {
String ALPHA_NUM_REGEX = "\\w+";
+ // Allow the special default table IDs
+ String ALPHA_NUM_REGEX_TABLE_ID = "[!+]?\\w+";
Review comment:
It occurs to me that these all should probably be `final`. I think `public
static` is implied since this is an interface, but I don't think `final` is
implied. I'm actually surprised this works, because I thought you could only
reference final strings in annotations. So, maybe `final` is implied for
strings in interfaces?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
