[ 
https://issues.apache.org/jira/browse/ACCUMULO-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281030#comment-16281030
 ] 

Adam J Shook edited comment on ACCUMULO-4751 at 12/6/17 11:05 PM:
------------------------------------------------------------------

[~elserj] ~Not too certain if we even need that block of code to update 
metadata for unused WALs in {{DataFileManager}}?~ Definitely need it.  The 
solutions I see now would be to 

1. Use {{StatusUtil.openWithUnknownLength(System.currentTimeMillis())}} here to 
add a {{createdTime}} to the metadata
2. Add the handling logic in the {{StatusMaker}} to set the {{createdTime}} to 
the WAL to the HDFS timestamp (#2 above) 
~3. Delete this block entirely (it might be needed at other times?  I don't 
know the pipeline at this level to know if we need to flag unused WALs)~


was (Author: adamjshook):
[~elserj] Not too certain if we even need that block of code to update metadata 
for unused WALs in {{DataFileManager}}?  The solutions I see now would be to 

1. Use {{StatusUtil.openWithUnknownLength(System.currentTimeMillis())}} here to 
add a {{createdTime}} to the metadata
2. Add the handling logic in the {{StatusMaker}} to set the {{createdTime}} to 
the WAL to the HDFS timestamp (#2 above) 
3. Delete this block entirely (it might be needed at other times?  I don't know 
the pipeline at this level to know if we need to flag unused WALs)

> Some WALs don't replicate due to lacking a createdTime entry
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-4751
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4751
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.3, 1.8.1
>            Reporter: Adam J Shook
>            Assignee: Adam J Shook
>         Attachments: repl_logs.txt
>
>
> From what I can tell, the below error is thrown when no data for a particular 
> table is written to a WAL, but the file is closed.  This would be because the 
> {{Status}} entry from the {{StatusUtil}} for {{fileClosed}} is pre-built and 
> therefore does not have a {{createdTime}}.  This prevents a WAL from being 
> replicated until a {{createdTime}} entry is added manually.
> From the Accumulo master:
> {code}
> Status record ([begin: 0 end: 0 infiniteEnd: true closed: true]) for 
> hdfs://namenode:9000/accumulo/wal/tserver.example.com+31732/f922df9c-3ffc-49ee-8d0c-261c7a05fea2
>  in table 7l was written to metadata table which lacked createdTime
> {code}
> There are two solutions I have in mind:
> 1. Update the {{StatusUtil}} such that every returned {{Status}} object sets 
> the {{createdTime}} to {{System.currentTimeMillis}} if not explicitly given.
> 2. Update the Accumulo Master to set the {{createdTime}} to the WAL's 
> modification time in HDFS if the WAL is closed but there is no 
> {{createdTime}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to