jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to
configure iterators or locality groups for new tables
URL: https://github.com/apache/accumulo/pull/337#discussion_r158021114
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java
##########
@@ -184,6 +186,7 @@ public NewTableConfiguration
setLocalityGroups(Map<String,Set<Text>> groups) {
String value = LocalityGroupUtil.encodeColumnFamilies(colFams);
tmp.put(Property.TABLE_LOCALITY_GROUP_PREFIX + entry.getKey(), value);
}
+ checkDisjoint(properties, tmp, "locality groups");
Review comment:
Since checkDisjoint is checking the keys rather than the values for
disjointness, performing the check at this point allowed any errors to be
discovered before performing the join on map values. Either location should
suffice, this was the earliest opportunity to perform the check.It won't bother
me if you prefer it to be located after the next put. If so, let me know and
I'll update the location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
