ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure
[Batch]Scanners are closed in ITs
URL: https://github.com/apache/accumulo/pull/341#discussion_r158129512
##########
File path:
test/src/main/java/org/apache/accumulo/test/ClientSideIteratorIT.java
##########
@@ -125,20 +125,25 @@ public void testVersioning() throws Exception {
bw.addMutation(m);
bw.flush();
- final Scanner scanner = conn.createScanner(tableName, new
Authorizations());
-
- final ClientSideIteratorScanner csis = new
ClientSideIteratorScanner(scanner);
- final IteratorSetting si = new IteratorSetting(10, "localvers",
VersioningIterator.class);
- si.addOption("maxVersions", "2");
- csis.addScanIterator(si);
-
- checkResults(csis, resultSet1, PartialKey.ROW_COLFAM_COLQUAL_COLVIS_TIME);
- checkResults(scanner, resultSet2,
PartialKey.ROW_COLFAM_COLQUAL_COLVIS_TIME);
-
- csis.fetchColumnFamily(new Text("colf"));
- checkResults(csis, resultSet1, PartialKey.ROW_COLFAM_COLQUAL_COLVIS_TIME);
- csis.clearColumns();
- csis.fetchColumnFamily(new Text("none"));
- assertFalse(csis.iterator().hasNext());
+ ClientSideIteratorScanner csis = null;
+ try (Scanner scanner = conn.createScanner(tableName, new
Authorizations())) {
Review comment:
It's possible to use try-with-resources for both `scanner` and `csis` in the
same block. I don't recall if the separating character is a semicolon or a
comma.
```java
try (Scanner scanner = conn.createScanner(tableName, Authorizations.EMPTY);
ClientSideIteratorScanner csis = new ClientSideIteratorScanner(scanner)) {
// ...
}
```
You can also nest them, but that's uglier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
