mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API
for Mutation
URL: https://github.com/apache/accumulo/pull/347#discussion_r158098926
##########
File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
##########
@@ -772,6 +772,236 @@ public void putDelete(byte[] columnFamily, byte[]
columnQualifier, ColumnVisibil
put(columnFamily, columnQualifier, columnVisibility.getExpression(), true,
timestamp, true, EMPTY_BYTES);
}
+ /**
+ * Fluent API for Mutation
+ *
+ * <p>
+ * Each step of the Mutation is represented by an interface. Inheritance
order ensures that chained methods follow prescribed order of:
+ *
+ * <p>
+ * row, family, qualifier, visibility, timestamp
+ *
+ * <p>
+ * set and delete methods end the chain and finalize the mutation
+ */
+ public interface RowStep extends FamilyStep {
+ FamilyStep row(byte[] r);
+
+ FamilyStep row(CharSequence r);
+
+ FamilyStep row(ByteBuffer r);
+
+ FamilyStep row(Text t);
Review comment:
A long term plan is to no longer use external data types likes Hadoop's
`Text` in Accumulo API. Not sure if it should be used in new API. Maybe
others can weigh in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
