ctubbsii commented on a change in pull request #345: ACCUMULO-4769 Sanity check
for valid CryptoModule and KeyEncryptionStrategy in config
URL: https://github.com/apache/accumulo/pull/345#discussion_r158139376
##########
File path:
core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java
##########
@@ -88,6 +90,33 @@ else if (!prop.getType().isValidFormat(value))
if (key.equals(Property.CRYPTO_CIPHER_KEY_ALGORITHM_NAME.getKey())) {
keyAlgorithm = Objects.requireNonNull(value);
}
+ if
(key.equals(Property.CRYPTO_SECRET_KEY_ENCRYPTION_STRATEGY_CLASS.getKey()) &&
!(value == null || value.equals("NullSecretKeyEncryptionStrategy"))) {
+ @SuppressWarnings("rawtypes")
Review comment:
Should not suppress warnings which can be addressed with proper generics
use. Can use `<?>` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
