[
https://issues.apache.org/jira/browse/ACCUMULO-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307151#comment-16307151
]
Christopher Tubbs commented on ACCUMULO-1972:
---------------------------------------------
Thanks, [~coffeethulhu]! Since you had more than one commit, my advice to use
{{HEAD~1}} was bad advice. I should have suggested to squash it first, or to do
{{git format-patch origin/1.7}} instead.
For expediency, rather than have you mess about further with git commands, I
will simply combine your previous patch with this git-formatted one, to produce
a single squashed commit in your local branch, with you as the author and based
on what we discussed. :) I will also update the commit message to provide a
little more detail about the change.
Thank you very much for investigating this bug and contributing the code to fix
it. Since this appears to be your first contribution to Accumulo, would you
like to be added to our 'people' page (https://accumulo.apache.org/people/)? If
so, you can perform a pull request to
https://github.com/apache/accumulo-website/blob/master/pages/people.md or
simply comment with the details you'd like to be added, and one of us can add
you directly.
Also, if you'd like your first contribution to be mentioned on Twitter, let us
know your Twitter handle and we can '@' mention you. :)
> Range constructors call overridable method
> ------------------------------------------
>
> Key: ACCUMULO-1972
> URL: https://issues.apache.org/jira/browse/ACCUMULO-1972
> Project: Accumulo
> Issue Type: Bug
> Affects Versions: 1.4.4, 1.5.0
> Reporter: Bill Havanki
> Assignee: Matthew Dinep
> Priority: Minor
> Labels: newbie
> Fix For: 1.7.4, 1.8.2, 2.0.0
>
> Attachments:
> 0001-ACCUMULO-1972-updated-beforeStartKey-to-private-impl.patch,
> accumulo-1972.patch, accumulo-1972_2.patch
>
>
> Several {{Range}} constructors call {{Range.beforeStartKey()}}, which is not
> final. This is dangerous:
> bq. The superclass constructor runs before the subclass constructor, so the
> overriding method in the subclass will get invoked before the subclass
> constructor has run. If the overriding method depends on any initialization
> performed by the subclass constructor, the method will not behave as
> expected. ??Item 17, Effective Java Vol. 2, Bloch??
> If {{beforeStartKey()}} cannot be made final, the code should be refactored
> to make the constructors safe.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
