joshelser commented on a change in pull request #347: ACCUMULO-4746 Fluent API
for Mutation
URL: https://github.com/apache/accumulo/pull/347#discussion_r161012119
##########
File path: core/src/test/java/org/apache/accumulo/core/data/MutationTest.java
##########
@@ -183,6 +185,190 @@ private Value nv(String s) {
return new Value(s.getBytes());
}
+ @Test
+ public void testAtFamilyTypes() {
+ final String fam = "f16bc";
+ final String qual = "q1pm2";
+ final String val = "v8672194923750";
+
+ Mutation expected = new Mutation("row5");
+ expected.put(fam, qual, val);
+
+ // Test all family methods, keeping qual and val constant as Strings
+ // fam: byte[]
+ Mutation actual = new Mutation("row5");
+ actual.at().family(fam.getBytes(UTF_8)).qualifier(qual).set(val);
Review comment:
> I was puzzling over this question and shared what I came up with on the
issue.
Thanks for the context, Keith.
> As long as the API call stays streamlined like below and the user doesn't
have to necessarily be aware of this new class in order to make modifications
on their Mutation.
Ya, that's what I was thinking. Less junk in one Java file. That has the
indirect benefit of preventing unintended changes to the existing public API of
Mutation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
