ctubbsii commented on a change in pull request #357: ACCUMULO-4611 Deprecate
commons config in api
URL: https://github.com/apache/accumulo/pull/357#discussion_r161852741
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java
##########
@@ -484,4 +547,157 @@ public ClientConfiguration withSasl(boolean saslEnabled)
{
public ClientConfiguration withSasl(boolean saslEnabled, String
kerberosServerPrimary) {
return withSasl(saslEnabled).with(ClientProperty.KERBEROS_SERVER_PRIMARY,
kerberosServerPrimary);
}
+
+ /**
Review comment:
Will update PR to include the rest. In an experiment to drop the deprecated
methods in the master branch, I noticed this also. Also, some of these methods
are actually being used in our code. I'll need to figure out which ones should
be left undeprecated, but still brought down into the child class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
