keith-turner commented on a change in pull request #361: ACCUMULO-4784 - Create
builder for Connector
URL: https://github.com/apache/accumulo/pull/361#discussion_r166725291
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java
##########
@@ -309,6 +311,26 @@ public boolean equals(Object o) {
return false;
}
+ private static <T> T merge(T o1, T o2) {
+ if (o1 != null)
+ return o1;
+ return o2;
+ }
+
+ public BatchWriterConfig merge(BatchWriterConfig other) {
Review comment:
This needs javadoc describing what it does and what it returns. Also needs
a since tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
