joshelser commented on a change in pull request #332: ACCUMULO-4826 Use the
hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r170426869
##########
File path: assemble/pom.xml
##########
@@ -323,5 +323,67 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>hadoop2</id>
+ <activation>
+ <property>
+ <!-- Hack around activeByDefault=true not working as we'd want -->
+ <name>!hadoop.profile</name>
+ </property>
+ </activation>
+ <properties>
+
<artifactList>commons-math3,commons-vfs2,gson,guava,htrace-core,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12</artifactList>
+
<assemblyDescriptor>src/main/assemblies/binary-release.xml</assemblyDescriptor>
+ </properties>
+ </profile>
+ <profile>
+ <id>hadoop3</id>
+ <activation>
+ <property>
+ <name>hadoop.profile</name>
+ <value>3</value>
+ </property>
+ </activation>
+ <properties>
+
<artifactList>commons-cli,commons-codec,commons-collections,commons-configuration,commons-io,commons-lang,commons-logging,commons-math3,commons-vfs2,gson,guava,htrace-core,htrace-core4,javax.servlet-api,jcommander,jetty-http,jetty-io,jetty-security,jetty-server,jetty-servlet,jetty-util,jline,libthrift,protobuf-java,slf4j-api,slf4j-log4j12</artifactList>
+
<assemblyDescriptor>src/main/assemblies/binary-release-hadoop3.xml</assemblyDescriptor>
+ </properties>
+ <!-- When using Hadoop 3 with the shaded jars, we need to provide
+ the jars we need instead of relying on
them externally. -->
Review comment:
Turns out we don't need any additions. The only artifact with an entry to
NOTICE is about a file that's only in the test jar (and thus we don't need to
include).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
