ctubbsii commented on a change in pull request #401: Fix ChaoticBalancerIT
URL: https://github.com/apache/accumulo/pull/401#discussion_r174987561
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
##########
@@ -163,14 +160,4 @@ public long
balance(SortedMap<TServerInstance,TabletServerStatus> current, Set<K
return 100;
}
-
- @Deprecated
- @Override
- public void init(ServerConfiguration conf) {
- throw new NotImplementedException();
Review comment:
This method has no impact at runtime inside the Accumulo master service. It
would only affect somebody calling it directly... and that would probably only
happen during testing. So, I *think* this exception would have been here to
prevent testing bugs (accidentally calling the wrong init during testing).
Might be best to leave it... though if our tests are correct, it should not
matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
