mikewalch commented on a change in pull request #20: Update bulkIngest example. Fixes #17 URL: https://github.com/apache/accumulo-examples/pull/20#discussion_r180566264
########## File path: docs/bulkIngest.md ########## @@ -24,10 +24,8 @@ test data are created in HDFS. After that the 1000 rows are ingested into accumulo. Then we verify the 1000 rows are in accumulo. $ PKG=org.apache.accumulo.examples.mapreduce.bulk - $ ARGS="-c examples.conf" - $ accumulo $PKG.SetupTable $ARGS -t test_bulk row_00000333 row_00000666 - $ accumulo $PKG.GenerateTestData --start-row 0 --count 1000 --output bulk/test_1.txt - $ accumulo-util hadoop-jar target/accumulo-examples-X.Y.Z.jar $PKG.BulkIngestExample $ARGS -t test_bulk --inputDir bulk --workDir tmp/bulkWork - $ accumulo $PKG.VerifyIngest $ARGS -t test_bulk --start-row 0 --count 1000 + $ accumulo $PKG.SetupTable + $ accumulo-util hadoop-jar target/accumulo-examples-*.jar $PKG.BulkIngestExample Review comment: You should link the Java classes used in this example. See the other examples for reference. This helps users easily find the classes so they can review the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services