mikewalch commented on a change in pull request #445: #408 - Fixed Kerberos ITs
URL: https://github.com/apache/accumulo/pull/445#discussion_r184711011
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/ClientConfConverter.java
##########
@@ -252,19 +251,10 @@ public static ClientConfiguration
toClientConf(AccumuloConfiguration conf) {
clientConf.setProperty(KERBEROS_SERVER_PRIMARY,
krbName.getServiceName());
}
- HashSet<String> clientKeys = new HashSet<>();
- for (ClientConfiguration.ClientProperty prop :
ClientConfiguration.ClientProperty.values()) {
- clientKeys.add(prop.getKey());
- }
-
- String key;
for (Map.Entry<String,String> entry : conf) {
- key = entry.getKey();
- if (clientKeys.contains(key)) {
- clientConf.setProperty(key, entry.getValue());
- }
+ String key = entry.getKey();
+ clientConf.setProperty(key, entry.getValue());
Review comment:
See 23c3044db
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
