keith-turner commented on a change in pull request #453: Add retry mechanism to
AccumuloReloadingVFSClassLoader.
URL: https://github.com/apache/accumulo/pull/453#discussion_r185232159
##########
File path:
start/src/main/java/org/apache/accumulo/start/classloader/vfs/AccumuloReloadingVFSClassLoader.java
##########
@@ -80,6 +86,35 @@ public void run() {
FileSystemManager vfs = AccumuloVFSClassLoader.generateVfs();
FileObject[] files = AccumuloVFSClassLoader.resolve(vfs, uris);
Review comment:
I don't fully understand the monitor.addfile case. I am curious why its
done when files.len is zero, but not when its greater than zero. Is that quick
to explain? If not I can look at the code outside the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
