ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add
@Override Annotations
URL: https://github.com/apache/accumulo/pull/476#discussion_r186583239
##########
File path: pom.xml
##########
@@ -1776,6 +1776,41 @@
<findbugs.excludeFilterFile>src/main/findbugs/exclude-filter.xml</findbugs.excludeFilterFile>
</properties>
</profile>
+ <profile>
+ <id>overrides</id>
Review comment:
Although added to check for overrides, the profile activates errorprone
compiler, and should probably be named `use-errorprone` or
`compile-with-errorprone` or similar.
Also, it might be worth adding a brief XML comment at the top of the profile
(above the `<id>`) to briefly explain what the profile is for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
