milleruntime commented on a change in pull request #484: Inline BlockFile interfaces. Fixes #480 URL: https://github.com/apache/accumulo/pull/484#discussion_r188402031
########## File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java ########## @@ -63,9 +58,9 @@ private CachableBlockFile() {} private static final Logger log = LoggerFactory.getLogger(CachableBlockFile.class); - public static class Writer implements BlockFileWriter { Review comment: Yeah I am hoping these changes open up more areas of improvement. I can do this next. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services