keith-turner commented on a change in pull request #489: #408 - Remove
deprecated ClientConfiguration from MapReduce API
URL: https://github.com/apache/accumulo/pull/489#discussion_r189289585
##########
File path:
client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
##########
@@ -353,17 +358,7 @@ protected static ClientConfiguration
getClientConfiguration(JobConf job) {
* @since 1.5.0
*/
protected static void validateOptions(JobConf job) throws IOException {
- final Instance inst = InputConfigurator.validateInstance(CLASS, job);
- String principal = InputConfigurator.getPrincipal(CLASS, job);
- AuthenticationToken token =
InputConfigurator.getAuthenticationToken(CLASS, job);
- // In secure mode, we need to convert the DelegationTokenStub into a real
DelegationToken
- token = ConfiguratorBase.unwrapAuthenticationToken(job, token);
- Connector conn;
- try {
- conn = inst.getConnector(principal, token);
- } catch (Exception e) {
- throw new IOException(e);
- }
+ Connector conn = InputConfigurator.getConnector(CLASS, job);
Review comment:
Nice refactoring
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
