milleruntime commented on a change in pull request #493: Make RFileScanner use
table props throughout
URL: https://github.com/apache/accumulo/pull/493#discussion_r190052738
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
##########
@@ -179,13 +181,16 @@ public void indexWeightChanged() {}
}
this.opts = opts;
+ if (null != opts.tableConfig && opts.tableConfig.size() > 0) {
+ ConfigurationCopy tableCC = new
ConfigurationCopy(DefaultConfiguration.getInstance());
+ opts.tableConfig.forEach(tableCC::set);
+ this.tableConf = tableCC;
+ } else {
+ this.tableConf = DefaultConfiguration.getInstance();
+ }
if (opts.indexCacheSize > 0 || opts.dataCacheSize > 0) {
- ConfigurationCopy cc = new
ConfigurationCopy(DefaultConfiguration.getInstance());
- if (null != opts.tableConfig) {
- opts.tableConfig.forEach(cc::set);
- }
-
+ ConfigurationCopy cc = new ConfigurationCopy(this.tableConf);
Review comment:
I made this.tableConf an AccumuloConfiguration object, which won't allow to
set properties for the block cache config. I can change it back to a
ConfigurationCopy object... I think it would be OK to set the cache properties
in the saved object. But this would basically revert changes Keith had
suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
