ctubbsii commented on a change in pull request #499: Implement new Encryption 
interface
URL: https://github.com/apache/accumulo/pull/499#discussion_r194883997
 
 

 ##########
 File path: 
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java
 ##########
 @@ -766,8 +614,9 @@ public long getRawSize() {
       version = new Version(this.in);
       Magic.readAndVerify(this.in);
 
-      // Do a version check
-      if (!version.compatibleWith(BCFile.API_VERSION) && 
!version.equals(BCFile.API_VERSION_1)) {
+      // Do a version check - API_VERSION_2 used experimental crypto 
parameters, no longer supported
+      if (!version.compatibleWith(BCFile.API_VERSION_3)
+          && !version.compatibleWith(BCFile.API_VERSION_1)) {
         throw new RuntimeException("Incompatible BCFile fileBCFileVersion.");
 
 Review comment:
   Do you need it to stay a RuntimeException? If so, there's an 
UncheckedIOException. Either IOException or a more specific RuntimeException 
would be fine with me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to