ctubbsii commented on a change in pull request #549: ACCUMULO-4074 Added support for multiple scan executors URL: https://github.com/apache/accumulo/pull/549#discussion_r200417343
########## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ########## @@ -430,12 +433,33 @@ "When a tablet server's SimpleTimer thread triggers to check idle" + " sessions, this configurable option will be used to evaluate update" + " sessions to determine if they can be closed due to inactivity"), + @Deprecated TSERV_READ_AHEAD_MAXCONCURRENT("tserver.readahead.concurrent.max", "16", PropertyType.COUNT, - "The maximum number of concurrent read ahead that will execute. This effectively" - + " limits the number of long running scans that can run concurrently per tserver."), + "This property is deprecated, use tserver.scan.executors.default.threads instead."), Review comment: Should not remove the old description, because it's still useful to know what it does, if anything. Also, please `s/deprecated/deprecated since 2.0.0/`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services