mikewalch commented on a change in pull request #556: Updated scan executor
prop docs
URL: https://github.com/apache/accumulo/pull/556#discussion_r201703445
##########
File path:
core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java
##########
@@ -117,7 +117,13 @@ void property(Property prop) {
// deal with multi-line values, skip strikethrough of value
defaultValue = strike("**default value:** ", depr) + "\n```\n" +
defaultValue + "\n```\n";
} else {
- defaultValue = strike("**default value:** " + "`" + defaultValue +
"`", depr);
+ if (prop.getType() == PropertyType.CLASSNAME
+ && defaultValue.startsWith("org.apache.accumulo.core")) {
Review comment:
I think this should be `startsWith("org.apache.accumulo")`. We can update
the jlink tag to handle different package prefeixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services