ctubbsii commented on a change in pull request #565: Removed usage of Instance
URL: https://github.com/apache/accumulo/pull/565#discussion_r203546076
##########
File path:
server/gc/src/main/java/org/apache/accumulo/gc/replication/CloseWriteAheadLogReferences.java
##########
@@ -129,12 +129,10 @@ public void run() {
/**
* Construct the set of referenced WALs from zookeeper
*
- * @param conn
- * Connector
* @return The Set of WALs that are referenced in the metadata table
*/
- protected HashSet<String> getClosedLogs(Connector conn) {
- WalStateManager wals = new WalStateManager(conn.getInstance(),
ZooReaderWriter.getInstance());
+ protected HashSet<String> getClosedLogs() {
+ WalStateManager wals = new WalStateManager(context,
ZooReaderWriter.getInstance());
Review comment:
This looks right, but be careful here. Replication code has two "clients",
and we need to make sure that if we're replacing any client API with an
internal type, we're doing so with the "local" system, and not the client code
which refers to the remote replica.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
