keith-turner commented on a change in pull request #585: ServerContext is now a 
singleton class
URL: https://github.com/apache/accumulo/pull/585#discussion_r209263895
 
 

 ##########
 File path: 
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java
 ##########
 @@ -297,7 +296,7 @@ private static boolean isValidColumn(ColumnUpdate cu) {
   }
 
   protected Arbitrator getArbitrator() {
-    return new ZooArbitrator();
+    return new ZooArbitrator(ServerContext.getInstance());
 
 Review comment:
   I think it would be good to open a follow on issue to explore ways to remove 
this.  There was a lot to look at so I may have missed some, but this is the 
only call I noticed to ServerContext.getInstance() that was not in a main 
method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to