milleruntime commented on a change in pull request #617: Removed duplicate
calls and implementation of SecureRandom
URL: https://github.com/apache/accumulo/pull/617#discussion_r213115226
##########
File path:
core/src/main/java/org/apache/accumulo/core/security/crypto/CryptoUtils.java
##########
@@ -41,23 +41,16 @@ public static SecureRandom getSha1SecureRandom() {
return getSecureRandom("SHA1PRNG", "SUN");
}
- public static SecureRandom getSecureRandom(String secureRNG, String
secureRNGProvider) {
+ private static SecureRandom getSecureRandom(String secureRNG, String
secureRNGProvider) {
Review comment:
You could name this method "newSecureRandom" and the other "newSha1" to show
that it is creating a new object every time it is called. This kinda goes
along with what I recently did in CryptoServiceFactory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
