milleruntime commented on a change in pull request #641: Fix crypto tests
writing to /tmp
URL: https://github.com/apache/accumulo/pull/641#discussion_r216706328
##########
File path:
core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java
##########
@@ -1787,137 +1789,146 @@ private void runVersionTest(int version,
AccumuloConfiguration aconf) throws IOE
reader.close();
}
- public static AccumuloConfiguration getAccumuloConfig(String
cryptoConfSetting) {
- return new
SiteConfiguration(CryptoTest.class.getClassLoader().getResource(cryptoConfSetting));
+ public static AccumuloConfiguration getAccumuloConfig(boolean cryptoOn) {
+ ConfigurationCopy cfg = new
ConfigurationCopy(DefaultConfiguration.getInstance());
+ if (cryptoOn) {
Review comment:
I like the simplicity of boolean but I guess I am spoiled by Intellij...
When I look at a function I see: getAccumuloConfig(cryptoOn: true);
In this case, keeping it a string would at least minimize the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
