keith-turner commented on a change in pull request #669: Use optimized writeV
methods in Mutations
URL: https://github.com/apache/accumulo/pull/669#discussion_r222059032
##########
File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
##########
@@ -1603,6 +1603,8 @@ private void oldReadFields(byte first, DataInput in)
throws IOException {
}
+ private final byte[] integerBuffer = new byte[4];
Review comment:
Yeah, but I think that is ok. I think a common use case after calling write
would be to discard the object. So I suspect their is no gain from the global
var and an opportunity for a tighter scope is missed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
