milleruntime commented on issue #706: Fix #705 TableName from baseSplit is ignored, when getting inputTableConfig within AbstractInputFormat.initialize() URL: https://github.com/apache/accumulo/pull/706#issuecomment-431093909 I see now, thanks @deniskuzZ. I think this is a valid change but I have a few concerns. I am worried that code previously written which calls getDefaultInputTableConfig() may expect to get the tableName from the JobConf and will break with this change. And since we follow SemVer, we can't change a method signature in the public API. This would require deprecating the old method and replacing it with a new one. My other concern is that we are trying to clean up the Map Reduce code for 2.0.0-Alpha release (it is a mess right now if you didn't notice, with too much exposed to the public API) so we may be deprecating this code for something better. In the meantime, I submitted a job to run all tests https://jenkins.revelc.net/job/Accumulo-PR/95/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
