cleroux opened a new pull request #745: Monitor 2.0: Minor bug fixes, chart updates URL: https://github.com/apache/accumulo/pull/745 Fixed avatar jumping left/right between small/medium layouts. When resizing the browser window between medium and small bootstrap layouts, the accumulo avatar (or "brand image" in bootstrap terms) was shifting position on the navbar. According to the [Bootstrap Navbar example](https://getbootstrap.com/docs/3.3/components/#navbar-brand-image), the image element should be inside the navbar-brand element. Fixed overview plots timeformat option not working because of a typo. Code was using "timeFormat" instead of "timeformat". It was supposed to display like '00:00<br>EDT' but it was defaulting to '00:00' I fixed the bug but I think I liked it better without the time zone. It looks really repetitive to show the time zone with every tick on ten charts. To me, it seems obvious that it's local time. If you feel it's appropriate I would like to remove the time zone from chart ticks. I simplified the creation of the charts by generalizing the chart options into one global style and one sub-style for the cache hit rate charts. The makePlot() function in functions.js became less useful to the point that I decided to eliminate it and consolidate all of that functionality in overview.js. I added a very slight background gradient to the charts. I felt they needed a bit of style. I also added a .plot CSS class to replace the inline styles on the chart divs. In addition to conforming to best practices, this change will also allow me to make the charts hoverable with tooltips in an upcoming pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
